chore: fix build and wrapper generation & regenerate #8
Conversation
|
There are still some things to fix. Hence back to draft. |
liamsi
force-pushed
the
ismail/fix-build_and_regenerate-wrappers
branch
from
d5630dd to
df82116
Compare
liamsi
changed the title
| ValsetUpdateEvent *wrappers.PeggyValsetUpdatedEvent | ||
| ERC20DeployedEvent *wrappers.PeggyERC20DeployedEvent | ||
| EventNonce uint64 | ||
| ValsetUpdateEvent *wrappers.QuantumGravityBridgeValidatorSetUpdatedEvent |
There was a problem hiding this comment.
The event PeggyTransactionBatchExecutedEvent was renamed in the contract to MessageTupleRootEvent. You could argue it's the only actual critical part of the contracts that needed to be modified. This PR is fine I think, but we need to replace the function that watched for PeggyTransactionBatchExecutedEvent with one that watches for MessageTupleRootEvent in the relayer (not sure why it's under the orchestrator).
|
|
||
| // RelayBatches checks the last validator set on Ethereum, if it's lower than our latest valida | ||
| // set then we should package and submit the update as an Ethereum transaction | ||
| func (s *peggyRelayer) RelayBatches(ctx context.Context) error { |
There was a problem hiding this comment.
This is probably what we want to replace with code to relay message tuple roots.
There was a problem hiding this comment.
Yeah, I but I feel this PR was already way, way too large 😬
There are a few things that need to be done:
- integration tests need to be cleaned up
- message tuple roots creating and add in that method here (above) and in the corresponding interface
- ValeSetRootHash needs to be created (note that the validators here used do additionally sign the valsetUpdates with a different signing key from the tendermint one as far as I understand; just noting that as it might be easier to keep it that way instead of changing everything to ecdsa in tendermint directly)
- ...
Tests will still fail but at least the build works again.
Fixes #7