refactor: remove unnecessary config.Seal() (backport #3786) (#3801)

- Add unit tests to cosmos SDK config set up
- Remove an unnecessary `config.Seal` invocation that has been around
for a [long
time](5e4a1dc#diff-9e0425d31b7cf4072a746feb0c6bc1e0045b639e01dd0b5ac2f08e8c2952c886R120)
but isn't necessary because the `init()` command always sets and seals
the config.<hr>This is an automatic backport of pull request #3786 done
by [Mergify](https://mergify.com).

---------

Co-authored-by: Rootul P <rootulp@gmail.com>

app/sdk_config.go

@@ -0,0 +1,15 @@
+package app
+
+import sdk "github.com/cosmos/cosmos-sdk/types"
+
+func init() {
+	setCosmosSDKConfig()
+}
+
+func setCosmosSDKConfig() {
+	config := sdk.GetConfig()
+	config.SetBech32PrefixForAccount(Bech32PrefixAccAddr, Bech32PrefixAccPub)
+	config.SetBech32PrefixForValidator(Bech32PrefixValAddr, Bech32PrefixValPub)
+	config.SetBech32PrefixForConsensusNode(Bech32PrefixConsAddr, Bech32PrefixConsPub)
+	config.Seal()
+}

app/sdk_config_test.go

@@ -0,0 +1,18 @@
+package app
+
+import (
+	"testing"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_setCosmosSDKConfig(t *testing.T) {
+	config := sdk.GetConfig()
+	assert.Equal(t, Bech32PrefixAccAddr, config.GetBech32AccountAddrPrefix())
+	assert.Equal(t, Bech32PrefixAccPub, config.GetBech32AccountPubPrefix())
+	assert.Equal(t, Bech32PrefixValAddr, config.GetBech32ValidatorAddrPrefix())
+	assert.Equal(t, Bech32PrefixValPub, config.GetBech32ValidatorPubPrefix())
+	assert.Equal(t, Bech32PrefixConsAddr, config.GetBech32ConsensusAddrPrefix())
+	assert.Equal(t, Bech32PrefixConsPub, config.GetBech32ConsensusPubPrefix())
+}

cmd/celestia-appd/cmd/root.go

@@ -121,9 +121,6 @@ func setDefaultConsensusParams(command *cobra.Command) error {
 }
 
 func initRootCmd(rootCmd *cobra.Command, encodingConfig encoding.Config) {
-	cfg := sdk.GetConfig()
-	cfg.Seal()
-
 	rootCmd.AddCommand(
 		genutilcli.InitCmd(app.ModuleBasics, app.DefaultNodeHome),
 		genutilcli.CollectGenTxsCmd(banktypes.GenesisBalancesIterator{}, app.DefaultNodeHome),