Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs: update non-interactive default rules #1063

Closed
2 tasks
Tracked by #650
rootulp opened this issue Nov 24, 2022 · 3 comments
Closed
2 tasks
Tracked by #650

specs: update non-interactive default rules #1063

rootulp opened this issue Nov 24, 2022 · 3 comments
Assignees
Labels
specs directly relevant to the specs

Comments

@rootulp
Copy link
Collaborator

rootulp commented Nov 24, 2022

Context

ADR 006 simplified the non-interactive default rules so the specs currently describe an outdated iteration of the non-interactive default rules.

Proposal

@rootulp rootulp added the specs directly relevant to the specs label Nov 24, 2022
@evan-forbes
Copy link
Member

moving the convo from ADR009 here

based on the above, my interpretation of the non-interactive default rules post ADR006 are:

If the message length is > k, then it must start on a new row.
If the message length is <= k, then it must begin at a location aligned with the largest power of 2 that is <= the message length.

@rootulp yeah, but to clarify I do think we should keep it to a single rule if possible, but perhaps that's just an opinion

Messages must begin at a location aligned with the largest power of 2 that is not larger than the message length or k.

@rootulp
Copy link
Collaborator Author

rootulp commented Nov 30, 2022

I've re-read this statement several times and find it really difficult to grok:

Messages must begin at a location aligned with the largest power of 2 that is not larger than the message length or k.

I think it may help readability if we articulate the scenarios as multiple statements. When written as one statement, the reader has to apply the rule to multiple scenarios (what happens when a message spans multiple rows? what happens when a message spans multiple rows only if placed after a message that occupies N shares at the beginning of the row? etc.)

I'm not strictly opposed to the one statement or strictly in favor of the two statements above but I find the previous and proposed non-interactive default rules really difficult to grok so would appreciate if we made them really explicit.

@evan-forbes
Copy link
Member

can close with #1905

@evan-forbes evan-forbes self-assigned this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
specs directly relevant to the specs
Projects
None yet
Development

No branches or pull requests

2 participants