Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that we are only removing txs from the block at the max square size #1102

Closed
Tracked by #1256
evan-forbes opened this issue Dec 9, 2022 · 1 comment
Closed
Tracked by #1256

Test that we are only removing txs from the block at the max square size #1102

evan-forbes opened this issue Dec 9, 2022 · 1 comment
Assignees
@cmwaters
Labels
testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

ideally we should only be hitting this if we're at the max squaresize. that might be something we want to add a test for in the future

Originally posted by @evan-forbes in #1089 (comment)

this test could be as simple adding an additional check to an existing test that creates square not the max square size, and ensure that each transaction is getting included in the block.
@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label Dec 19, 2022
@evan-forbes evan-forbes mentioned this issue Jan 17, 2023
Closed
5 tasks
@evan-forbes evan-forbes added this to the Mainnet milestone Jan 17, 2023
This was referenced Jan 17, 2023
Closed
Closed
@cmwaters cmwaters self-assigned this Feb 6, 2023
@cmwaters cmwaters mentioned this issue Feb 6, 2023
Merged
cmwaters added a commit that referenced this issue Feb 7, 2023
@cmwaters
testing: add extra tests to ensure we remove txs correctly (#1345)
580d186 
Addresses: #1102
evan-forbes pushed a commit that referenced this issue Feb 27, 2023
@cmwaters @evan-forbes
testing: add extra tests to ensure we remove txs correctly (#1345)
5e7635e 
Addresses: #1102
@cmwaters
Copy link
Contributor

Closing this as I believe it has been solved through this test:

celestia-app/pkg/square/builder_test.go

Line 86 in c121c28

func TestBuilderRejectsBlobTransactions(t *testing.T) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmwaters @evan-forbes