Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broader scope QGB documentation #1946

Closed
rach-id opened this issue Jun 16, 2023 · 0 comments · Fixed by #1974
Closed

Broader scope QGB documentation #1946

rach-id opened this issue Jun 16, 2023 · 0 comments · Fixed by #1974
Assignees
@rach-id
Labels
documentation Improvements or additions to documentation

Comments

@rach-id
Copy link
Member

rach-id commented Jun 16, 2023 

          nice update! I think this will pair well with a higher level (but still very technical) document about trust assumptions, broader scope/connection contracts, etc whenever we get around to it.

no blocking comments, just some questions. I'll take a second review after chewing on it as well

Originally posted by @evan-forbes in #1911 (review)
@rach-id rach-id added documentation Improvements or additions to documentation x/qgb labels Jun 16, 2023
@rach-id rach-id self-assigned this Jun 19, 2023
@rach-id rach-id mentioned this issue Jun 21, 2023
Merged
5 tasks
rach-id added a commit that referenced this issue Jul 11, 2023
@rach-id @evan-forbes
@cmwaters @rootulp @staheri14
docs: add the QGB overview document (#1974)
9de969c 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Closes: #1946

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
rach-id added a commit to rach-id/celestia-app that referenced this issue Sep 7, 2023
@rach-id
docs: add the QGB overview document (celestiaorg#1974)
f14a07b 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->

Closes: celestiaorg#1946

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
(cherry picked from commit 9de969c)
rach-id added a commit that referenced this issue Sep 8, 2023
@rach-id
docs: add the QGB overview document (#1974)
31ec367 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->

Closes: #1946

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
(cherry picked from commit 9de969c)
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rach-id @evan-forbes
@cmwaters @rootulp @staheri14
docs: add the QGB overview document (#1974)
8bc9da2 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Closes: celestiaorg/celestia-app#1946

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add the QGB overview document rach-id/celestia-app
1 participant
@rach-id