Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI workflow that runs goreleaser check #2452

Closed
MSevey opened this issue Sep 8, 2023 · 1 comment · Fixed by #2652
Closed

Add CI workflow that runs goreleaser check #2452

MSevey opened this issue Sep 8, 2023 · 1 comment · Fixed by #2652
Assignees
@rootulp
Labels
CI item that directly relates to or modify the CI good first issue Good for newcomers

Comments

@MSevey
Copy link
Member

MSevey commented Sep 8, 2023 •
edited by rootulp
Loading

Context

Originally posted by @rootulp in #2437 (review)

Proposal

Should we add a CI workflow that runs goreleaser check to make sure that the .goreleaser.yaml is always valid?
@rootulp rootulp changed the title Add goreleaser check to linter Add CI workflow that runs goreleaser check Sep 8, 2023
@rootulp rootulp added good first issue Good for newcomers CI item that directly relates to or modify the CI and removed needs:triage labels Sep 8, 2023
@rootulp rootulp self-assigned this Oct 10, 2023
@rootulp
Copy link
Collaborator

rootulp commented Oct 10, 2023

We're considering adding more distributions / architectures in #2567 so I think it makes sense to do this now.

@rootulp rootulp mentioned this issue Oct 10, 2023
Merged
rootulp added a commit that referenced this issue Oct 13, 2023
@rootulp
ci: check if goreleaser config is valid (#2652)
93868b9 
Closes #2452

## Testing

Tested on my fork

```
/opt/hostedtoolcache/goreleaser-action/1.21.2/x64/goreleaser check
  • checking                                 path=
  • 1 configuration file(s) validated
  • thanks for using goreleaser!
```

Ref:
https://github.com/rootulp/celestia-app/actions/runs/6473546638/job/17576484916?pr=39#step:3:16
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
ci: check if goreleaser config is valid (#2652)
af8b448 
Closes celestiaorg/celestia-app#2452

## Testing

Tested on my fork

```
/opt/hostedtoolcache/goreleaser-action/1.21.2/x64/goreleaser check
  • checking                                 path=
  • 1 configuration file(s) validated
  • thanks for using goreleaser!
```

Ref:
https://github.com/rootulp/celestia-app/actions/runs/6473546638/job/17576484916?pr=39#step:3:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
CI item that directly relates to or modify the CI good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: check if goreleaser config is valid rootulp/celestia-app
2 participants
@rootulp @MSevey