Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register gRPC gateway routes #2837

Closed
4 tasks
jaybxyz opened this issue Nov 13, 2023 · 1 comment · Fixed by #2838
Closed
4 tasks

Register gRPC gateway routes #2837

jaybxyz opened this issue Nov 13, 2023 · 1 comment · Fixed by #2838
Labels
bug Something isn't working

Comments

@jaybxyz
Copy link
Contributor

jaybxyz commented Nov 13, 2023

Summary of Bug

The blob and blobstream modules lack registration for the gRPC Gateway routes, leading to the inability to query the following endpoints:

Version

The main branch as well as v1.3.0

Steps to Reproduce

Run a local chain by running the following available script, and go to http://localhost:1317/blob/v1/params.

./single-node.sh

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jaybxyz jaybxyz added the bug Something isn't working label Nov 13, 2023
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Nov 13, 2023

Given that this requires a minor fix, I am pleased to contribute. Here is PR #2838 already.

evan-forbes pushed a commit that referenced this issue Nov 14, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->
This PR fixes #2837. 

Both `blob` and `blobstream` modules lack registration for the gRPC
Gateway routes, leading to the inability to query endpoints. Let me know
if there is anything i need to do to merge this PR.

CI checks require 3 workflows awaiting approval.

## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords
mergify bot pushed a commit that referenced this issue Nov 14, 2023
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
This PR fixes #2837.

Both `blob` and `blobstream` modules lack registration for the gRPC
Gateway routes, leading to the inability to query endpoints. Let me know
if there is anything i need to do to merge this PR.

CI checks require 3 workflows awaiting approval.

## Checklist

<!--
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [x] Linked issues closed with keywords

(cherry picked from commit b75c7e3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant