Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCLITestSuite/TestCmdQueryTally: race detected during execution of test #2938

Closed
rootulp opened this issue Dec 15, 2023 · 1 comment · Fixed by #2941
Closed

TestCLITestSuite/TestCmdQueryTally: race detected during execution of test #2938

rootulp opened this issue Dec 15, 2023 · 1 comment · Fixed by #2941
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 15, 2023

Context

https://github.com/celestiaorg/celestia-app/actions/runs/7213226413/job/19652627299#step:4:3749

Problem

test-race fails on TestCLITestSuite/TestCmdQueryTally

Proposal

  1. [short term] Skip the test during test-race
  2. [long term] Fix the data race
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 15, 2023

Long term fix is tracked in #1369

@rootulp rootulp mentioned this issue Dec 15, 2023
Merged
@rootulp rootulp self-assigned this Dec 15, 2023
rootulp added a commit that referenced this issue Dec 18, 2023
@rootulp
test: skip TestCLITestSuite in race mode (#2941)
233e711 
Closes #2938 by doing
the short term fix
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp
test: skip TestCLITestSuite in race mode (#2941)
2be2cc7 
Closes celestiaorg/celestia-app#2938 by doing
the short term fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: skip TestCLITestSuite in race mode rootulp/celestia-app
1 participant
@rootulp