Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for arabica-11 in download-genesis command #2976

Closed
rootulp opened this issue Jan 2, 2024 · 2 comments · Fixed by #2978
Closed

Add support for arabica-11 in download-genesis command #2976

rootulp opened this issue Jan 2, 2024 · 2 comments · Fixed by #2978
Assignees
@subhajit20
Labels
good first issue Good for newcomers warn:blocked item is not currently being worked on but is still blocked

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 2, 2024

Context

A new testnet is being deployed: https://github.com/celestiaorg/devops/issues/692

Problem

The download-genesis command only supports hard-coded chain-ids. See

celestia-app/cmd/celestia-appd/cmd/download_genesis.go

Lines 15 to 22 in 95496d9

// chainIDToSha256 is a map of chainID to the SHA-256 hash of the genesis file for that chain ID.
// To add a new chain-id, download the genesis file from the networks repo and compute the SHA-256 hash.
// Add the chain-id and hash to this map.
var chainIDToSha256 = map[string]string{
"celestia": "9727aac9bbfb021ce7fc695a92f901986421283a891b89e0af97bc9fad187793",
"mocha-4": "0846b99099271b240b638a94e17a6301423b5e4047f6558df543d6e91db7e575",
"arabica-10": "fad0a187669f7a2c11bb07f9dc27140d66d2448b7193e186312713856f28e3e1",
}

Proposal

After arabica-11 is deployed, add it to the list of supported chain-ids.
@rootulp rootulp added good first issue Good for newcomers warn:blocked item is not currently being worked on but is still blocked labels Jan 2, 2024
@subhajit20
Copy link
Contributor

subhajit20 commented Jan 3, 2024 •
edited
Loading

Hey I want to work on this.
Can you assign this issue to me? @rootulp

@subhajit20 subhajit20 mentioned this issue Jan 3, 2024
Merged
@subhajit20
Copy link
Contributor

hey @rootulp , made a pr as of now and after adding the arabic-11 I will add the hash right there.

rootulp added a commit that referenced this issue Jan 3, 2024
@subhajit20 @rootulp
feat: add support for arabica-11 in download-genesis command (#2978)
5f224ae 
Closes #2976

## Testing

Updated the help and error messages to include arabica-11
```
$ ./build/celestia-appd download-genesis --help
Download genesis file from https://github.com/celestiaorg/networks.
The first argument should be a known chain-id. Ex. celestia, mocha-4, arabica-10, arabica-11

$ ./build/celestia-appd download-genesis arabaica-12
Error: unknown chain-id: arabaica-12. Must be: celestia, mocha-4, arabica-10, arabica-11
```

Downloading arabica-11 genesis works
```
$ ./build/celestia-appd download-genesis arabica-11
Downloading genesis file for arabica-11 to /Users/rootulp/.celestia-app/config/genesis.json
Downloaded genesis file for arabica-11 to /Users/rootulp/.celestia-app/config/genesis.json
SHA-256 hash verified for arabica-11
```

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@subhajit20 @rootulp
feat: add support for arabica-11 in download-genesis command (#2978)
c7860e1 
Closes celestiaorg/celestia-app#2976

## Testing

Updated the help and error messages to include arabica-11
```
$ ./build/celestia-appd download-genesis --help
Download genesis file from https://github.com/celestiaorg/networks.
The first argument should be a known chain-id. Ex. celestia, mocha-4, arabica-10, arabica-11

$ ./build/celestia-appd download-genesis arabaica-12
Error: unknown chain-id: arabaica-12. Must be: celestia, mocha-4, arabica-10, arabica-11
```

Downloading arabica-11 genesis works
```
$ ./build/celestia-appd download-genesis arabica-11
Downloading genesis file for arabica-11 to /Users/rootulp/.celestia-app/config/genesis.json
Downloaded genesis file for arabica-11 to /Users/rootulp/.celestia-app/config/genesis.json
SHA-256 hash verified for arabica-11
```

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@subhajit20 subhajit20

Labels
good first issue Good for newcomers warn:blocked item is not currently being worked on but is still blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for arabica-11 in download-genesis command subhajit20/celestia-app
2 participants
@rootulp @subhajit20