Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the file keyring backend as a default #405

Closed
Tracked by #514
evan-forbes opened this issue May 13, 2022 · 4 comments
Closed
Tracked by #514

Use the file keyring backend as a default #405

evan-forbes opened this issue May 13, 2022 · 4 comments
Assignees

Comments

@evan-forbes
Copy link
Member

In order to simplify keyring use, celestia-node will be using the file keyring backend as a default. In order to stay consistent and avoid possible confusion for users, we should investigate exactly what this entails, and then make a decision on switching the backend here as well.

@rootulp
Copy link
Collaborator

rootulp commented Dec 20, 2022

Is this issue coupled to the celestia-node implementation of the same? The celestia-node side isn't implemented yet: celestiaorg/celestia-node#603 and https://github.com/celestiaorg/celestia-node/blob/0c2669574fcbc8478cf9572ae5d36c98901916e8/nodebuilder/state/keyring.go#L25

@cmwaters
Copy link
Contributor

Is there a justification anywhere about why file over os? - is it just to simplify things?

@evan-forbes
Copy link
Member Author

cc @renaynay do you remember the exact reason for switching?

@renaynay
Copy link
Member

renaynay commented Jan 4, 2023

os is wonky on macos cc @evan-forbes @cmwaters

0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
- [x] closes celestiaorg/celestia-app#405
- [x] manually test that default value is switched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants