Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ledger-go 1.0.0 to fix support for Ledger Nano S+ #4106

Closed
3 tasks done
rootulp opened this issue Dec 10, 2024 · 4 comments · Fixed by #4146
Closed
3 tasks done

Upgrade to ledger-go 1.0.0 to fix support for Ledger Nano S+ #4106

rootulp opened this issue Dec 10, 2024 · 4 comments · Fixed by #4146
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 10, 2024

Context

osmosis-labs/osmosis#8872

Problem

There may be an issue with the latest Ledger software.

Proposal

@rootulp rootulp self-assigned this Dec 10, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 10, 2024

We use

celestia-app/go.mod

Lines 258 to 260 in 818026a

// Pin to ledger-cosmos-go v0.12.4 to avoid a breaking change introduced in v0.13.0
// The following replace statement can be removed when we upgrade to cosmos-sdk >= v0.50.0
github.com/cosmos/ledger-cosmos-go => github.com/cosmos/ledger-cosmos-go v0.12.4
and the linked PR bumps https://github.com/zondax/ledger-go which we only depend on indirectly
github.com/zondax/ledger-go v0.14.3 // indirect

@rootulp rootulp added investigation item tracks efforts related to an investigation. does not always require a PR to close. needs:investigation more knowledge is required before item can be groomed and removed needs:triage labels Dec 10, 2024
@rootulp
Copy link
Collaborator Author

rootulp commented Dec 13, 2024

Based on this comment the issue only impacts Ledger Nano S+.

We could theoretically replace the transitive dep github.com/zondax/ledger-go v0.14.3 with github.com/zondax/ledger-go v1.0.0 but I'm inclined to wait for https://github.com/cosmos/ledger-cosmos-go to cut a new release that bumps their dependency of ledger-go to v1.0.0 so will monitor cosmos/ledger-cosmos-go#70.

@rootulp rootulp added warn:blocked item is not currently being worked on but is still blocked and removed investigation item tracks efforts related to an investigation. does not always require a PR to close. needs:investigation more knowledge is required before item can be groomed labels Dec 13, 2024
@rootulp rootulp changed the title Investigate ledger-go 1.0.0 Upgrade to ledger-go 1.0.0 to fix support for Ledger Nano S+ Dec 13, 2024
@PaddyMc
Copy link

PaddyMc commented Dec 18, 2024

I agree, I'm hoping for a bump in the ledger-cosmos-go app as well, and bump that

@rootulp
Copy link
Collaborator Author

rootulp commented Dec 19, 2024

https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.14.0 was released an hour ago so we can bump to that here. Note, we need to make a change in our cosmos-sdk to bump to v0.14.0 b/c v0.13.x included a breaking change. See

celestia-app/go.mod

Lines 257 to 259 in 415e870

// Pin to ledger-cosmos-go v0.12.4 to avoid a breaking change introduced in v0.13.0
// The following replace statement can be removed when we upgrade to cosmos-sdk >= v0.50.0
github.com/cosmos/ledger-cosmos-go => github.com/cosmos/ledger-cosmos-go v0.12.4

The breaking change in ledger-cosmos-go: cosmos/ledger-cosmos-go#39
The PR in cosmos-sdk that bumps ledger-cosmos-go to v0.13.x: cosmos/cosmos-sdk#14661

@rootulp rootulp removed the warn:blocked item is not currently being worked on but is still blocked label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants