Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ledger-cosmos-go v0.14.0 #423

Closed
rootulp opened this issue Dec 19, 2024 · 0 comments · Fixed by #424
Closed

Upgrade to ledger-cosmos-go v0.14.0 #423

rootulp opened this issue Dec 19, 2024 · 0 comments · Fixed by #424
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 19, 2024

Context

celestiaorg/celestia-app#4106

Problem

We need to upgrade to https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.14.0 to pick up a fix for Ledger Nano S+ devices.

Currently this repo is on

github.com/cosmos/ledger-cosmos-go v0.12.4

cosmos-ledger-go v0.13.x contains a breaking change.
The breaking change in ledger-cosmos-go: cosmos/ledger-cosmos-go#39
The PR in cosmos-sdk that bumps ledger-cosmos-go to v0.13.x: cosmos#14661

Proposal

  1. Cherry-pick the PR that bumps ledger-cosmos-go to v0.13.x update: that PR is huge. I'm only cherry-picking a subset that is enables the breaking change. See fix: signing with Ledger throws an empty error #349
  2. Then bump to ledger-cosmos-go v0.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant