-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: signing with Ledger throws an empty error #349
fix: signing with Ledger throws an empty error #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, thanks for handling this
Codecov Report
@@ Coverage Diff @@
## release/v0.46.x-celestia #349 +/- ##
============================================================
- Coverage 65.57% 65.57% -0.01%
============================================================
Files 666 666
Lines 71177 71188 +11
============================================================
+ Hits 46677 46679 +2
- Misses 21916 21925 +9
Partials 2584 2584
|
c226e8b
into
celestiaorg:release/v0.46.x-celestia
I am late here, but FWIW we got Zondax to create https://github.com/cosmos/ledger-cosmos-go/releases/tag/v0.12.3 with the fix as well. |
Thanks for the info! If cosmos/cosmos-sdk v0.46.x gets bumped to ledger-cosmos-go v0.12.3 then we can revert this PR and pull that change into celestiaorg/cosmos-sdk. I'll stay tuned for a cosmos-sdk v0.46.x release with it |
* fix: bump ledger-cosmos-go * feat: update cosmos-sdk code for ledger-cosmos-go Inspired by cosmos#14661
Bumps to ledger-cosmos-go v.0.13.1 to fix celestiaorg/celestia-app#2650. Unblocks celestiaorg/celestia-app#2668
Notes for reviewers
go mod tidy
Testing
Verified this fixes the issue here