Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the protobuf generator to be the same as Cosmos-sdk one #553

Closed
4 tasks
rach-id opened this issue Jul 21, 2022 · 0 comments · Fixed by #667
Closed
4 tasks

Update the protobuf generator to be the same as Cosmos-sdk one #553

rach-id opened this issue Jul 21, 2022 · 0 comments · Fixed by #667
Assignees
@rahulghangas
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Jul 21, 2022

Summary

The current protobuf generator used for celestia-app is old and needs to be updated

Problem Definition

We currently rely on an old version of tendermintdev/sdk-proto-gen to generate protobuf wrappers.
This gives us issues when using for example the Any type implementation from the cosmos-sdk.
Also, it would be good to be using the same version as cosmos-sdk.

Proposal

Update the version and make necessary changes

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@rach-id rach-id added the enhancement New feature or request label Jul 21, 2022
@rach-id rach-id changed the title Update the protobuf generator to follow latest changes on Cosmos-sdk Update the protobuf generator to be the same as Cosmos-sdk one Jul 21, 2022
@rach-id rach-id mentioned this issue Jul 21, 2022
Merged
@evan-forbes evan-forbes added the good first issue Good for newcomers label Jul 23, 2022
@rahulghangas rahulghangas mentioned this issue Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulghangas rahulghangas

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Celestia Node
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update protobuf generator rahulghangas/celestia-app
3 participants
@rahulghangas @rach-id @evan-forbes