Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf generator #667

Merged
merged 8 commits into from
Aug 29, 2022

Conversation

rahulghangas
Copy link
Contributor

@rahulghangas rahulghangas commented Aug 26, 2022

Closes #553

Update protbuf generator to follow the version in cosmos-sdk upstream - published v0.45.8

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #667 (5d70826) into main (301f9df) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   38.54%   38.50%   -0.05%     
==========================================
  Files          19       19              
  Lines        2532     2535       +3     
==========================================
  Hits          976      976              
- Misses       1472     1475       +3     
  Partials       84       84              
Impacted Files Coverage Δ
x/payment/types/tx.pb.gw.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@evan-forbes
Copy link
Member

evan-forbes commented Aug 26, 2022

@sweexordious, when you get the chance, can you see if this messes with the qgb-integration branch, or perhaps even fixes our issue Any?

@rahulghangas rahulghangas changed the title Chore/update protobuf gen Update protobuf generator Aug 26, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. Great work fixing this, will also test it on the QGB side and see

Makefile Outdated Show resolved Hide resolved
proto/buf.gen.gogo.yaml Outdated Show resolved Hide resolved
@rach-id
Copy link
Member

rach-id commented Aug 26, 2022

@evan-forbes QGB branch is working fine with this change. However, it is not fixing the Any type problem that we have. We might need to probably tweak the configuration.

evan-forbes
evan-forbes previously approved these changes Aug 26, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking @sweexordious 🙂

👍

Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 👍

@rahulghangas rahulghangas merged commit 276a999 into celestiaorg:main Aug 29, 2022
@rahulghangas rahulghangas deleted the chore/update-protobuf-gen branch August 29, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update the protobuf generator to be the same as Cosmos-sdk one
4 participants