-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf generator #667
Update protobuf generator #667
Conversation
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 38.54% 38.50% -0.05%
==========================================
Files 19 19
Lines 2532 2535 +3
==========================================
Hits 976 976
- Misses 1472 1475 +3
Partials 84 84
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@sweexordious, when you get the chance, can you see if this messes with the qgb-integration branch, or perhaps even fixes our issue Any? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. Great work fixing this, will also test it on the QGB side and see
@evan-forbes QGB branch is working fine with this change. However, it is not fixing the |
Co-authored-by: CHAMI Rachid <chamirachid1@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for checking @sweexordious 🙂
👍
9ad9663
to
5d70826
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff 👍
Closes #553
Update protbuf generator to follow the version in cosmos-sdk upstream - published
v0.45.8