chore!: bump sdk v0.46.13 and core v0.34.28 #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
added
the
consensus breaking
evan-forbes
commented
Jun 11, 2023
Comment on lines
-17
to
+19
| sdkCtx, err := app.NewProcessProposalQueryContext() | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| // create a context using a branch of the state and loaded using the | ||
| // proposal height and chain-id | ||
| sdkCtx := app.NewProposalContext(core.Header{ChainID: app.GetChainID(), Height: app.LastBlockHeight() + 1}) |
There was a problem hiding this comment.
for posteriety, if we don't do this, then the signatures of some txs will get rejected because the chain-id and height is not consistently loaded into the context, resulting in PrepareProposal filtering out those transactions, and therefore those txs get caught in the mempool, which always produces confusing errors.
Why not main first and then backport to v1.x? In the past, we've had a bot that you can use to open the same PR on a backported branch |
, but we need this on main ofc
|
ok, we can go through main closing in favor of #1912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bumps to our forks of the cosmos-sdk and comet to their latest versions. This is consensus breaking because an event was modified in the sdk, although that event may or may not have gotten hit on mocha-2 already.
aiming towards v1.x atm for max
, but we need this on main ofc
blocked by celestiaorg/cosmos-sdk#326, celestiaorg/cosmos-sdk#324, celestiaorg/celestia-core#1021