feat!: reserve the last 256 namespaces for protocol use (backport #2257) #2261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
liamsi,
adlerjohn,
evan-forbes,
rootulp and
cmwaters
as code owners
|
This reverts commit 25b2df7.
Closes #2143 De-duplicate `ValidateBlobNamespace` and export it from `x/blob/types` package. The namespace package needs to define its own `isBlobNamespace` because it can't import `ValidateBlobNamespace` from `x/blob/types` as that would introduce a circular dependency.
…to IsReserved function (#2194) Closes ##2138 This PR also addresses the concerns raised in the [comment](#2138 (comment)) by introducing a distinction between two types of reserved namespaces. Namespaces within the range [0-255] are now identified as "Primary Reserved Namespaces," while any other reserved namespaces beyond this range are categorized as "Non-Primary Reserved Namespaces." Hopefully, this differentiation provides better clarity and organization regarding namespace allocation and usage within the code. - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [x] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
|
Note: I think we should not squash when we merge this PR b/c each commit (with the exception of the first two) is a separate logical change that occurred on |
evan-forbes
approved these changes
Aug 14, 2023
cmwaters
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back-port the following commits from main to v1.x:
Instead of just cherry-picking the last one because then we'd have to maintain a slight divergence between main and v1.x.
Since the pre-ceeding commits were easy to cherry-pick too, this PR brings v1.x closer to main.