ci: add goreleaser-check as a require step for the goreleaser build #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSevey
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2772 +/- ##
=======================================
Coverage 19.70% 19.70%
=======================================
Files 139 139
Lines 17005 17005
=======================================
Hits 3350 3350
Misses 13333 13333
Partials 322 322 |
|
moved to needs of version_bump to fail sooner. |
rootulp
previously approved these changes
Oct 26, 2023
MSevey
changed the title
rootulp
added a commit
that referenced
this pull request
Oct 26, 2023
rootulp
approved these changes
Oct 26, 2023
rach-id
approved these changes
Oct 26, 2023
evan-forbes
approved these changes
Oct 27, 2023
evan-forbes
added
the
backport:v1.x
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
…2772) <!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Minor update I saw when debugging the CI. This will ensure that the goreleaser step won't run if the goreleaser check fails. This will just clean up the error log a little bit. (cherry picked from commit 36ecb01)
rootulp
added a commit
that referenced
this pull request
Oct 31, 2023
…backport #2772) (#2775) This is an automatic backport of pull request #2772 done by [Mergify](https://mergify.com). --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details> --------- Co-authored-by: Matthew Sevey <mjsevey@gmail.com> Co-authored-by: Rootul Patel <rootulp@gmail.com>
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this pull request
Aug 1, 2024
Forward ports celestiaorg/celestia-app#2751 to main FYI: may introduce merge conflicts with celestiaorg/celestia-app#2772 cc: @MSevey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor update I saw when debugging the CI. This will ensure that the goreleaser step won't run if the goreleaser check fails. This will just clean up the error log a little bit.