feat: download-genesis command (backport #2791)
#2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #2777 Note for reviewers: I'd rather not backport this PR to v1.x b/c it's a new feature and not a bug fix. I wanted to have it ready in case ppl do want it on v1.x ## Testing Works for all 3 known networks. Complains on an unknown network ```shell $ ./build/celestia-appd download-genesis mocha-4 Downloading genesis file for mocha-4 to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for mocha-4 to /Users/rootulp/.celestia-app/config/genesis.json SHA-256 hash verified for mocha-4 $ ./build/celestia-appd download-genesis celestia Downloading genesis file for celestia to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for celestia to /Users/rootulp/.celestia-app/config/genesis.json SHA-256 hash verified for celestia $ ./build/celestia-appd download-genesis arabica-10 Downloading genesis file for arabica-10 to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for arabica-10 to /Users/rootulp/.celestia-app/config/genesis.json SHA-256 hash verified for arabica-10 $ ./build/celestia-appd download-genesis foo Error: unknown chain-id: foo. Must be: celestia, mocha-4, or arabica-10. ``` I verified the chain ID actually differs for each file: ```shell $ ./build/celestia-appd download-genesis mocha-4 && cat ~/.celestia-app/config/genesis.json | jq ."chain_id" Downloading genesis file for mocha-4 to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for mocha-4 to /Users/rootulp/.celestia-app/config/genesis.json SHA-256 hash verified for mocha-4 "mocha-4" $ ./build/celestia-appd download-genesis celestia && cat ~/.celestia-app/config/genesis.json | jq ."chain_id" Downloading genesis file for celestia to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for celestia to /Users/rootulp/.celestia-app/config/genesis.json SHA-256 hash verified for celestia "celestia" ``` I tampered with the hard-coded Arabica hash and it correctly identified the mismatch: ```shell $ ./build/celestia-appd download-genesis arabica-10 Downloading genesis file for arabica-10 to /Users/rootulp/.celestia-app/config/genesis.json Downloaded genesis file for arabica-10 to /Users/rootulp/.celestia-app/config/genesis.json Error: sha256 hash mismatch: got fad0a187669f7a2c11bb07f9dc27140d66d2448b7193e186312713856f28e3e1, expected fad0a187669f7a2c11bb07f9dc27140d66d2448b7193e186312713856f28e3e2 ``` --------- Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com> (cherry picked from commit c34a93d) # Conflicts: # cmd/celestia-appd/cmd/root.go
mergify
bot
requested review from
evan-forbes,
rootulp and
cmwaters
as code owners
rootulp
approved these changes
Oct 31, 2023
rach-id
approved these changes
Oct 31, 2023
evan-forbes
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #2791
Testing