chore: include calculated and proposed data root in log message #2826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2826 +/- ##
==========================================
+ Coverage 19.44% 19.59% +0.15%
==========================================
Files 143 143
Lines 17320 17320
==========================================
+ Hits 3368 3394 +26
+ Misses 13633 13607 -26
Partials 319 319
|
rootulp
approved these changes
Nov 8, 2023
Comment on lines
161
to
+162
| if !bytes.Equal(dah.Hash(), req.Header.DataHash) { | ||
| logInvalidPropBlock(app.Logger(), req.Header, "proposed data root differs from calculated data root") | ||
| logInvalidPropBlock(app.Logger(), req.Header, fmt.Sprintf("proposed data root %X differs from calculated data root %X", req.Header.DataHash, dah.Hash())) |
There was a problem hiding this comment.
evan-forbes
approved these changes
Nov 8, 2023
cmwaters
added
the
backport:v1.x
mergify bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
(cherry picked from commit fb8492c)
cmwaters
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.