Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused store keys #2881

Merged
merged 2 commits into from
Nov 30, 2023
Merged

chore: remove unused store keys #2881

merged 2 commits into from
Nov 30, 2023

Conversation

cmwaters
Copy link
Contributor

@cmwaters cmwaters commented Nov 30, 2023

This removes the memory and store keys in the blob keeper as they are not needed.

In addition it cleans up some of the testing in the blob package

@cmwaters cmwaters self-assigned this Nov 30, 2023
@cmwaters cmwaters marked this pull request as ready for review November 30, 2023 17:16
Copy link
Contributor

coderabbitai bot commented Nov 30, 2023

Walkthrough

Walkthrough

The changes across various Go files indicate a refactoring in the codebase, particularly within the keeper package of a module. The refactoring involves removing the usage of store keys from several functions and structures, suggesting a design shift away from using these keys directly. The tests have been updated to reflect these changes, with a new CreateKeeper function introduced to replace the old pattern of keeper instantiation. The package names have been updated to keeper_test, indicating a move towards black-box testing.

Changes

File Path Change Summary
app/app.go Removed blobmoduletypes.StoreKey from the New function and its initialization.
x/blob/keeper/gas_test.go, x/blob/keeper/genesis_test.go, x/blob/keeper/grpc_query_params_test.go, x/blob/keeper/params_test.go Changed package to keeper_test, replaced old keeper creation with CreateKeeper function, and updated test functions accordingly.
x/blob/keeper/keeper.go Removed storetypes import, storeKey, and memKey from Keeper struct and updated NewKeeper function signature.
x/blob/keeper/keeper_test.go Changed package to keeper_test, added CreateKeeper function, updated TestPayForBlobs to use CreateKeeper, and added new imports.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

x/blob/keeper/gas_test.go Show resolved Hide resolved
@cmwaters cmwaters merged commit 35b76bf into main Nov 30, 2023
31 checks passed
@cmwaters cmwaters deleted the cal/remove-unused-keys branch November 30, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants