feat: reset tally after quorum has reached

[cmwaters]

Closes: #2877

The base branch was changed.

[coderabbitai]

Walkthrough

Walkthrough

The changes involve an optimization of the upgrade signaling mechanism within a blockchain application. The upgrade keeper now includes a ResetTally method that is called from the EndBlocker function when a new version is detected, clearing votes for versions that are no longer relevant. Additionally, the order of validation checks in the SignalVersion method has been adjusted for efficiency.

Changes

File Path	Change Summary
app/app.go	Added a call to app.UpgradeKeeper.ResetTally in the EndBlocker function to reset the tally when a new version is detected.
x/upgrade/keeper.go	Modified the SignalVersion method order of checks and added ResetTally method to reset the tally after a version change.
x/upgrade/tally_test.go	Added tests for the new ResetTally logic to ensure it clears votes and resets values correctly.

Assessment against linked issues

Objective	Addressed	Explanation
#2877: Improve computational efficiency of the upgrade signalling mechanism by deleting votes after an upgrade and tallying periodically.	✅	The addition of the ResetTally method addresses the objective of deleting votes after an upgrade to improve computational efficiency. The change summary does not mention tallying periodically, but the reset mechanism could be part of such an optimization.
#2877: Ensure that the validator exists before setting its version in the SignalVersion method.	✅	The change in the order of validation checks in the SignalVersion method ensures that the existence of a validator is confirmed before setting its version, which aligns with the objective.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json