Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: versioned constant getters #2915

Merged
merged 2 commits into from
Dec 9, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Dec 8, 2023

Context

During a 1:1 w/ @evan-forbes , we noticed that the versioned constant getters don't have any unit tests.

@rootulp rootulp self-assigned this Dec 8, 2023
@rootulp rootulp force-pushed the rp/test-versioned-constants branch from 25bd86b to eb95f7f Compare December 8, 2023 20:49
@rootulp rootulp force-pushed the rp/test-versioned-constants branch from fcc499e to df6bf08 Compare December 8, 2023 20:52
@rootulp rootulp changed the title test: versioned constants test: versioned constant getters Dec 8, 2023
@rootulp rootulp marked this pull request as ready for review December 8, 2023 20:54
Copy link
Contributor

coderabbitai bot commented Dec 8, 2023

Walkthrough

Walkthrough

The changes involve the introduction of new test functions in the appconsts_test package to ensure the correctness of constants across different versions of the appconsts package. These tests are designed to verify the values of constants related to subtree root thresholds and square size upper bounds in various package versions. Additionally, there have been modifications to the constants within the appconsts, testground, v1, and v2 packages, likely to align with new requirements or specifications.

Changes

File Path Change Summary
pkg/appconsts/versioned_consts_test.go Added test functions TestSubtreeRootThreshold and TestSquareSizeUpperBound.
pkg/appconsts/.../v1 Modified constants Version, SubtreeRootThreshold, and SquareSizeUpperBound.
pkg/appconsts/.../v2 Modified constants Version, SubtreeRootThreshold, and SquareSizeUpperBound.
pkg/appconsts/.../testground Modified constants Version, SubtreeRootThreshold, and SquareSizeUpperBound.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label Dec 8, 2023
@rootulp rootulp merged commit 14db3df into celestiaorg:main Dec 9, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants