Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pkg): typo fix #2920

Merged
merged 2 commits into from
Dec 11, 2023
Merged

chore(pkg): typo fix #2920

merged 2 commits into from
Dec 11, 2023

Conversation

Pan-chao
Copy link
Contributor

minor typo fix, two of them are variable, rest are comments

have a good week-end

Copy link
Contributor

coderabbitai bot commented Dec 10, 2023

Walkthrough

Walkthrough

The changes involve minor text corrections and a variable name fix in the codebase. Comments in a global constants file have been updated to correct typos, while a test file for a wrapper has had a variable name corrected from verfied to verified, which likely resolves a logical error and ensures proper control flow in the test scenarios.

Changes

File Path Change Summary
.../global_consts.go Corrected typos in comments for ShareInfoBytes and DataCommitmentBlocksLimit.
.../nmt_wrapper_test.go Changed variable name from verfied to verified, affecting logic and control flow.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@celestia-bot celestia-bot requested a review from a team December 10, 2023 00:40
@rootulp rootulp enabled auto-merge (squash) December 11, 2023 02:18
@rootulp rootulp merged commit 98ae11d into celestiaorg:main Dec 11, 2023
29 checks passed
Copy link

gitpoap-bot bot commented Dec 11, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

rootulp pushed a commit to rootulp/celestia-app that referenced this pull request Dec 11, 2023
minor typo fix, two of them are variable, rest are comments 

have a good week-end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants