-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(txsim): add CLI Flag for chainID #2934
Conversation
WalkthroughThe code changes introduce a new CLI flag for specifying the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
we need to add prefix |
…bs/celestia-app into minh/add-chainID-flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM. Thanks for the contribution! Defer to @staheri14 and @cmwaters for another review + merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I have left one comment.
Also, would like to defer it to other reviewers for the final approval.
I believe here is the describe of go.work.sum and we also have an on going issue related to changes of go.work.sum in here. I think we don't have to track it for now. wdyt @staheri14 @phamminh0811 |
Based on #2471 (comment) it looks like we may not need this PR. Thoughts @cmwaters ? |
Overview
Close #2471
This pr adding CLI Flag for chainID in txsim and make txsim runs with chainID option.
Checklist