-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Ethereum signatures verification + refactor the orchestrator/relayer for testing #314
Conversation
Codecov Report
@@ Coverage Diff @@
## qgb-integration #314 +/- ##
==================================================
Coverage ? 14.12%
==================================================
Files ? 50
Lines ? 9196
Branches ? 0
==================================================
Hits ? 1299
Misses ? 7806
Partials ? 91 Continue to review full report at Codecov.
|
@evan-forbes I think this PR can be merged so that the upcoming changes can be tracked in separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, nice additions, and sets us up for future changes
@@ -1,4 +1,7 @@ | |||
4d63.com/gochecknoglobals v0.0.0-20201008074935-acfc0b28355a/go.mod h1:wfdC5ZjKSPr7CybKEcgJhUOgeAQW1+7WcyK8OvUilfo= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is go.sum
being modified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we keep adding new dependencies etc, I guess
…ayer for testing (celestiaorg#314) * temporary disables listening for valsets and query for latest valset instead * app client listening for arbitrary events for valsets * temporary disable signatures for testing * temporarily disable threshold checks for relayer * update count in end blocker * fixes orchestrator listening to valset events * fix orchestrator signatures + enables checks on msg_server + makes bridgeId a const * fixes signature tests + adds new checks * adds todo * remove unnecessary comment * adds todo * adds todo * moves the signer outside of the NewAppClient * cosmetics * updates singe node script to only create one validator * uncomments the threshold for querying two third data commitment confirms * linter checks + cosmetics fixes * cosmetics * removes todo
No description provided.