feat: gRPC server for TxStatus endpoint #3754
Conversation
cmwaters
changed the title
cmwaters
requested review from
staheri14 and
evan-forbes
and removed request for
a team
WalkthroughWalkthroughThe recent changes introduce a gRPC service for transaction handling in the Celestia application. This includes the implementation of the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
| node, err := s.clientCtx.GetNode() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| txID, err := hex.DecodeString(req.TxId) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.InvalidArgument, "invalid tx id: %s", err) | ||
| } | ||
|
|
||
| resTx, err := node.TxStatus(ctx, txID) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
after we move node initialization to the app and have access to the dbs, it would soooo nice if we would just move the logic here and not wrap the existing rpc
There was a problem hiding this comment.
Yeah, although I don't think proxying through the local RPC has much overhead
cmwaters
added
backport:v1.x
Yes I think we should |
Closes: #3753 This in some ways ties into https://github.com/celestiaorg/celestia-app/issues/3421<hr>This is an automatic backport of pull request #3754 done by [Mergify](https://mergify.com). --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Closes: #3753 This in some ways ties into https://github.com/celestiaorg/celestia-app/issues/3421<hr>This is an automatic backport of pull request #3754 done by [Mergify](https://mergify.com). --------- Co-authored-by: Callum Waters <cmwaters19@gmail.com>
Closes: #3753
This in some ways ties into #3421