Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: guide to modify param via governance #3832

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Aug 28, 2024

I created a doc to prepare for #3827

@rootulp rootulp self-assigned this Aug 28, 2024
@rootulp rootulp requested review from liamsi and a team as code owners August 28, 2024 19:40
@rootulp rootulp requested review from cmwaters and ninabarbakadze and removed request for a team August 28, 2024 19:40
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Walkthrough

Walkthrough

A new document titled "Modify Param" has been introduced to guide users in modifying governance parameters within the Celestia application. It provides a structured approach for changing the AllowMessages parameter in the icahost subspace, detailing prerequisites, proposal creation, submission, voting, and verification of changes.

Changes

Files Change Summary
docs/maintainers/modify-param.md Introduction of a comprehensive guide for modifying governance parameters, focusing on AllowMessages.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Governance Module
    participant Validator

    User->>Governance Module: Verify current value of `AllowMessages`
    User->>User: Create `proposal.json` with changes
    User->>Governance Module: Submit proposal
    Governance Module->>Validator: Notify proposal submission
    Validator->>Governance Module: Vote on proposal
    Governance Module->>User: Confirm proposal status
    User->>Governance Module: Verify updated `AllowMessages`
Loading

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b9ff23d and 0645d1e.

Files selected for processing (1)
  • docs/maintainers/modify-param.md (1 hunks)
Additional comments not posted (2)
docs/maintainers/modify-param.md (2)

5-13: LGTM!

The prerequisites section is clear and correctly formatted.

The code changes are approved.


40-48: LGTM!

The section for verifying the parameter value after the proposal passes is clear and correctly formatted.

The code changes are approved.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested review from evan-forbes and removed request for liamsi August 28, 2024 19:40
@celestia-bot celestia-bot requested a review from a team August 28, 2024 19:40
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
docs/maintainers/modify-param.md (1)

15-38: Add brief explanations for each command.

The commands are clear and correctly formatted. However, adding brief explanations for each command would improve readability and understanding.

Consider adding explanations like this:

# Create a proposal.json file with the desired changes
echo '{"title": "Modify ICA host allow messages", "description": "Modify ICA host allow messages", "changes": [{"subspace": "icahost", "key": "AllowMessages", "value": ["/ibc.applications.transfer.v1.MsgTransfer","/cosmos.bank.v1beta1.MsgSend","/cosmos.staking.v1beta1.MsgDelegate","/cosmos.staking.v1beta1.MsgBeginRedelegate","/cosmos.staking.v1beta1.MsgUndelegate","/cosmos.staking.v1beta1.MsgCancelUnbondingDelegation","/cosmos.distribution.v1beta1.MsgSetWithdrawAddress","/cosmos.distribution.v1beta1.MsgWithdrawDelegatorReward","/cosmos.distribution.v1beta1.MsgFundCommunityPool","/cosmos.gov.v1.MsgVote","/cosmos.feegrant.v1beta1.MsgGrantAllowance","/cosmos.feegrant.v1beta1.MsgRevokeAllowance"]}], "deposit": "10000000000utia"}' > proposal.json

# Export a variable for the key that will be used to submit the proposal
export FROM="validator"
export FEES="210000utia"
export GAS="auto"
export GAS_ADJUSTMENT="1.5"

# Submit the proposal
celestia-appd tx gov submit-legacy-proposal param-change proposal.json --from $FROM --fees $FEES --gas $GAS --gas-adjustment $GAS_ADJUSTMENT --yes

# Query the proposals
celestia-appd query gov proposals --output json | jq .

# Export a variable for the relevant proposal ID based on the output from the previous command
export PROPOSAL_ID=1

# Vote yes on the proposal
celestia-appd tx gov vote $PROPOSAL_ID yes --from $FROM --fees $FEES --gas $GAS --gas-adjustment $GAS_ADJUSTMENT --yes

@rootulp rootulp enabled auto-merge (squash) August 28, 2024 20:59
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol at the example

We might even want a version of this on our docs for others to know

@rootulp rootulp merged commit 8bfa251 into celestiaorg:main Aug 29, 2024
33 checks passed
ninabarbakadze pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants