feat: increase max-recv-msg-size default to 20 MiB (backport #4205) #4221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Closes #4204 Note this won't modify already existing `app.toml` files so node operators need to modify their local `app.toml`. Example command: ```shell sed -i.bak 's/^max-recv-msg-size = "10485760"/max-recv-msg-size = "20971520"/' ~/.celestia-app/config/app.toml ``` ## Testing ```shell # Before $ cat ~/.celestia-app/config/app.toml | grep max-recv max-recv-msg-size = "10485760" # After $ ./scripts/single-node.sh $ cat ~/.celestia-app/config/app.toml | grep max-recv max-recv-msg-size = "20971520" ``` (cherry picked from commit c620c12)
rootulp
approved these changes
Jan 14, 2025
celestia-bot
requested review from
a team and
evan-forbes
and removed request for
a team
rach-id
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4204
Note this won't modify already existing
app.tomlfiles so node operators need to modify their localapp.toml. Example command:Testing