Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump core to v1.2.4-tm-v0.35.6 #475

Merged
merged 2 commits into from
Jun 13, 2022
Merged

bump core to v1.2.4-tm-v0.35.6 #475

merged 2 commits into from
Jun 13, 2022

Conversation

evan-forbes
Copy link
Member

Description

pull all the latest changes from tendermint + our fixes

closes: #XXXX

@evan-forbes evan-forbes added dependencies Pull requests that update a dependency file C: Celestia app labels Jun 7, 2022
@evan-forbes evan-forbes self-assigned this Jun 7, 2022
@evan-forbes evan-forbes changed the title bump core to 35.6 bump core to v1.2.3.-tm-v0.35.6 Jun 7, 2022
rach-id
rach-id previously approved these changes Jun 7, 2022
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI apparently needs to be restarted.

@evan-forbes
Copy link
Member Author

evan-forbes commented Jun 7, 2022

LGTM. The CI apparently needs to be restarted.

this is actually a bug that I've been digging into the past few hours. I'm not sure exactly what is going on or if its relevant to tendermint, but it doesn't pop up in the previous v0.35. For some reason, when two validators are used in the big block test, they prematurely start new rounds

@evan-forbes evan-forbes marked this pull request as draft June 7, 2022 20:22
@evan-forbes
Copy link
Member Author

This is blocked by celestiaorg/celestia-core#783

@codecov-commenter
Copy link

Codecov Report

Merging #475 (2dff0b3) into master (1c357cb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   25.18%   25.18%           
=======================================
  Files          15       15           
  Lines        1930     1930           
=======================================
  Hits          486      486           
  Misses       1401     1401           
  Partials       43       43           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c357cb...2dff0b3. Read the comment docs.

@evan-forbes evan-forbes changed the title bump core to v1.2.3.-tm-v0.35.6 bump core to v1.2.4-tm-v0.35.6 Jun 11, 2022
@evan-forbes
Copy link
Member Author

This is blocked by celestiaorg/celestia-core#783

this isn't the case any longer as we instead changed the default peer gossip timeout, which fixed the failing test mentioned earlier

@evan-forbes evan-forbes marked this pull request as ready for review June 11, 2022 19:17
@evan-forbes evan-forbes merged commit 92803f6 into master Jun 13, 2022
@evan-forbes evan-forbes deleted the evan/bump-core-35.6 branch June 13, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

unsafe-reset command panics Node gets stuck in a loop while shutting down
5 participants