-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump core to v1.2.4-tm-v0.35.6 #475
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CI apparently needs to be restarted.
this is actually a bug that I've been digging into the past few hours. I'm not sure exactly what is going on or if its relevant to tendermint, but it doesn't pop up in the previous v0.35. For some reason, when two validators are used in the big block test, they prematurely start new rounds |
This is blocked by celestiaorg/celestia-core#783 |
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 25.18% 25.18%
=======================================
Files 15 15
Lines 1930 1930
=======================================
Hits 486 486
Misses 1401 1401
Partials 43 43 Continue to review full report at Codecov.
|
this isn't the case any longer as we instead changed the default peer gossip timeout, which fixed the failing test mentioned earlier |
Description
pull all the latest changes from tendermint + our fixes
closes: #XXXX