-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for universal nonce, fixes/improves relayer and depends on latest QGB contract #497
Add support for universal nonce, fixes/improves relayer and depends on latest QGB contract #497
Conversation
Codecov Report
@@ Coverage Diff @@
## qgb-integration #497 +/- ##
===================================================
+ Coverage 10.33% 11.74% +1.41%
===================================================
Files 63 65 +2
Lines 12872 10860 -2012
===================================================
- Hits 1330 1276 -54
+ Misses 11455 9494 -1961
- Partials 87 90 +3
Continue to review full report at Codecov.
|
This PR still has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still reviewing some more other parts more in depth, but the first pass looks good and only had a few comments
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does a lot of stuff:
Update the QGB implementation to support Universal nonce #467
Update the state machine to support the universal nonce approach #468
Update the QGB orchestrator to support universal nonce #469
Update the QGB Relayer to support universal nonce #470,
It's a huge PR, I agree. But, I didn't wanna waste more time doing everything separately and waiting for it to be reviewed and merge, mostly because all these issues were related.
After merging this, we will have the first working QGB version 🎉 🎉