Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for universal nonce, fixes/improves relayer and depends on latest QGB contract #497

Merged
merged 24 commits into from
Jun 24, 2022

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Jun 23, 2022

Does a lot of stuff:

It's a huge PR, I agree. But, I didn't wanna waste more time doing everything separately and waiting for it to be reviewed and merge, mostly because all these issues were related.

After merging this, we will have the first working QGB version 🎉 🎉

@rach-id rach-id added the enhancement New feature or request label Jun 23, 2022
@rach-id rach-id requested a review from evan-forbes June 23, 2022 19:47
@rach-id rach-id self-assigned this Jun 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #497 (934a5a0) into qgb-integration (b8ebb36) will increase coverage by 1.41%.
The diff coverage is 7.38%.

@@                 Coverage Diff                 @@
##           qgb-integration     #497      +/-   ##
===================================================
+ Coverage            10.33%   11.74%   +1.41%     
===================================================
  Files                   63       65       +2     
  Lines                12872    10860    -2012     
===================================================
- Hits                  1330     1276      -54     
+ Misses               11455     9494    -1961     
- Partials                87       90       +3     
Impacted Files Coverage Δ
e2e/qgb/qgb_network.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_data_commitment.go 0.00% <0.00%> (ø)
x/qgb/keeper/keeper_data_commitment_confirm.go 42.85% <ø> (-14.84%) ⬇️
x/qgb/keeper/msg_server.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_attestation.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_data_commitment_confirm.go 71.42% <ø> (-11.56%) ⬇️
x/qgb/keeper/query_valset.go 0.00% <0.00%> (ø)
x/qgb/keeper/query_valset_confirm.go 64.28% <ø> (ø)
x/qgb/orchestrator/codec.go 0.00% <0.00%> (ø)
x/qgb/orchestrator/deploy_command.go 0.00% <0.00%> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ebb36...934a5a0. Read the comment docs.

@rach-id
Copy link
Member Author

rach-id commented Jun 23, 2022

This PR still has the Any type import issue... Can we address that in a separate PR?

Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still reviewing some more other parts more in depth, but the first pass looks good and only had a few comments

.github/workflows/test.yml Show resolved Hide resolved
x/qgb/orchestrator/querier.go Show resolved Hide resolved
x/qgb/orchestrator/relayer.go Outdated Show resolved Hide resolved
x/qgb/keeper/keystore/keycache.go Show resolved Hide resolved
x/qgb/keeper/query_data_commitment_confirm_test.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/codec.go Outdated Show resolved Hide resolved
x/qgb/orchestrator/errors.go Outdated Show resolved Hide resolved
Co-authored-by: Evan Forbes <42654277+evan-forbes@users.noreply.github.com>
@rach-id rach-id changed the title Attestation interface Add support for universal nonce, fixes/improves relayer and depends on latest QGB contract Jun 24, 2022
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

x/qgb/abci.go Show resolved Hide resolved
x/qgb/abci.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants