Update to the lazyledger packages instead of tendermint and the cosmos-sdk #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
adlerjohn,
liamsi,
tac0turtle,
musalbas and
tzdybal
|
Looks good to me! Wondering if we shouldn't merge in the CI changes (#8) first? |
tzdybal
reviewed
Jan 26, 2021
|
Do you mind elaborating a bit, @tzdybal? I'm not quite sure what This branch has been tested to start a new chain, but it does not use starport for that. If you're talking about adding further scaffolding, then the answer is that any additions will have to be patched similarly to what was done to this branch before they could be added. |
Merged
liamsi
reviewed
Jan 30, 2021
evan-forbes
force-pushed
the
evan/replace-tendermint
branch
2 times, most recently
from
080f261
to
6f16b81
Compare
|
I'm still trying to figure out the last |
evan-forbes
force-pushed
the
evan/replace-tendermint
branch
from
072f7a2
to
18fdb67
Compare
switch to using lazyledger-core and the fork of the sdk update to the latest verison of lazyledger-core use the latest version of lazyledger-core and the lazyledger fork of the sdk gofmt gofmt ci fix: add the make proto-lint command switch to the lazyledger-core proto files remove redundant message types
update from deprecated cli command add version to buf.yaml change lazyledger-app proto package declaration in accordance with buf linting
evan-forbes
force-pushed
the
evan/replace-tendermint
branch
from
18fdb67
to
644d2d2
Compare
|
Ok, now we're good to go. The only CI failure is because we don't have any tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the replace directive to use the latest LazyLedger fork of the cosmos-sdk, along with manually replacing tendermint with lazyledger-core
Closes #4