Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show celestia version in the RPC status endpoint #1035

Closed
cmwaters opened this issue Jul 13, 2023 · 1 comment · Fixed by #1036
Closed

Show celestia version in the RPC status endpoint #1035

cmwaters opened this issue Jul 13, 2023 · 1 comment · Fixed by #1036
Assignees
@cmwaters

Comments

@cmwaters
Copy link
Contributor

We need some way of working out which version of Celestia users are using. Currently, /status returns a version but it is the version of Tendermint.

Proposal

Take the Version field returned in the Info ABCI call and plumb it into the node info that gets displayed in the /status endpoint (as well as in the p2p handshake)
@cmwaters cmwaters self-assigned this Jul 13, 2023
@cmwaters cmwaters mentioned this issue Jul 13, 2023
Merged
@rootulp
Copy link
Collaborator

rootulp commented Jul 13, 2023

[Question] why does the celestia-app version need to be propagated in the /status endpoint? Are the /abci_info or /node_info endpoints not sufficient?

This was referenced Sep 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwaters cmwaters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass software version from abci to node info celestiaorg/celestia-core
2 participants
@rootulp @cmwaters