Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify Tendermint CompatMode in chain config in config.toml #3623

Closed
5 tasks
rootulp opened this issue Sep 16, 2023 · 2 comments · Fixed by #3667
Closed
5 tasks

Ability to specify Tendermint CompatMode in chain config in config.toml #3623

rootulp opened this issue Sep 16, 2023 · 2 comments · Fixed by #3667
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR I: configuration Internal: related to Hermes configuration
Milestone

Comments

@rootulp
Copy link
Contributor

rootulp commented Sep 16, 2023

Summary

Add the ability to explicitly set the Tendermint CompatMode in chain config in config.toml.

Problem Definition

Celestia currently uses Tendermint v0.34.x but it has overridden the version field of the abci_info endpoint to return the application version (i.e. v1.0.0-rc14) and not the Tendermint version. See celestiaorg/celestia-core#1035 and celestiaorg/celestia-core#1036 for more details.

As a result, of the code here and here, Hermes falls back to Tendermint compat mode v0.37 which breaks for celestia-app. More context on how this breaks in #3620.

Proposal

Add the ability to explicitly set the Tendermint CompatMode in chain config in config.toml. If a chain doesn't specify it in chain config, then I think the current mechanism should be used where it is fetched from abci_info and falls back to v0.37.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Sep 16, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Sep 18, 2023
@seanchen1991 seanchen1991 added this to the v1.8 milestone Sep 18, 2023
@seanchen1991 seanchen1991 added the I: configuration Internal: related to Hermes configuration label Sep 18, 2023
@romac
Copy link
Member

romac commented Oct 4, 2023

Thanks for the suggestion, and sorry you've had to work around this. We'll get to this after the v1.7 release!

@romac romac added the A: blocked Admin: blocked by another (internal/external) issue or PR label Oct 5, 2023
@romac
Copy link
Member

romac commented Oct 5, 2023

Blocked until informalsystems/tendermint-rs#1367 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR I: configuration Internal: related to Hermes configuration
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants