Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Blockparts optimitzation if necessary #1079

Open
evan-forbes opened this issue Sep 13, 2023 · 2 comments
Open

Backport Blockparts optimitzation if necessary #1079

evan-forbes opened this issue Sep 13, 2023 · 2 comments
Labels
ice-box issues are automatically assigned this label until they are planned. T:optimization Type: Optimization

Comments

@evan-forbes
Copy link
Member

We should backport cometbft/cometbft#904 if necessary
@evan-forbes evan-forbes added the T:optimization Type: Optimization label Sep 13, 2023
@cmwaters
Copy link
Contributor

It's not a fix so much as an optimization. It does look like something worth backporting if we don't implement compact blocks first.

This looks like a breaking change so it would have to be released in v2

cmwaters pushed a commit that referenced this issue Sep 20, 2023
@mergify @sergio-mena
Log proposer's address when correctly accepting a proposal (backport #…
30895df 
…1079) (#1222)

* Log proposer's address when correctly accepting a proposal (#1079)

* Log proposer when logging received proposal

* Addressed review comments

* Promote updates to validator to Info level

(cherry picked from commit cf23082)

# Conflicts:
#	consensus/state.go
#	state/execution.go

* Revert "Log proposer's address when correctly accepting a proposal (#1079)"

This reverts commit 8ccdb00e9023da91ae324c86956ffe5a5851d1a3.

* Log proposer's address when correctly accepting a proposal (#1079)

* Log proposer when logging received proposal

* Addressed review comments

* Promote updates to validator to Info level

---------

Co-authored-by: Sergio Mena <sergio@informal.systems>
@faddat
Copy link
Contributor

faddat commented Sep 21, 2023

I think it is a very good idea to backport this.

@evan-forbes evan-forbes changed the title Backport Blockparts fix if necessary Backport Blockparts optimitzation if necessary Sep 21, 2023
@lasarojc lasarojc mentioned this issue Dec 6, 2023
Closed
@evan-forbes evan-forbes added the ice-box issues are automatically assigned this label until they are planned. label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ice-box issues are automatically assigned this label until they are planned. T:optimization Type: Optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faddat @cmwaters @evan-forbes