Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a migration script for the breaking config in v0.34.x #1299

Closed
evan-forbes opened this issue Apr 12, 2024 · 3 comments
Closed

Implement a migration script for the breaking config in v0.34.x #1299

evan-forbes opened this issue Apr 12, 2024 · 3 comments
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols WS: v2 ✌️

Comments

@evan-forbes
Copy link
Member

          > I would still like to understand the release strategy for this breaking change.

this is a good point, and we should document this. in the past, we've briefly discussed using a migration script. In a similar vein to a migration script, if we know what the error is, then we can automatically fix the config and log it should that error occur.

Originally posted by @evan-forbes in #1290 (comment)

for more context on this, there is a bug in viper that stops it from properly reading yaml. See #1143 and #1141

@cmwaters
Copy link
Contributor

There was an attempt at automatically migrating config files in CometBFT. I think the tool was left behind so not sure if it's currently in use at all

@evan-forbes evan-forbes added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols WS: v2 ✌️ labels Apr 15, 2024
@rootulp
Copy link
Collaborator

rootulp commented Apr 16, 2024

A config migration script seems prone to error and IMO warrants a lot of additional testing. We can circumvent that effort by deprecating the current config that is influxdb specific and adding new config.

@evan-forbes
Copy link
Member Author

evan-forbes commented Apr 16, 2024

closing as this is no longer needed due to renaming everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WS: Big Blonks 🔭 Improving consensus critical gossiping protocols WS: v2 ✌️
Projects
None yet
Development

No branches or pull requests

3 participants