Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The trace client fails to restrict which tables are traced #1141

Closed
evan-forbes opened this issue Nov 27, 2023 · 0 comments · Fixed by #1144
Closed

The trace client fails to restrict which tables are traced #1141

evan-forbes opened this issue Nov 27, 2023 · 0 comments · Fixed by #1144
Assignees
Labels
T:Bug Type: Bug (confirmed)

Comments

@evan-forbes
Copy link
Member

The trace client is supposed to have the ability to select what is traced. This is currently not case, where everything gets traced. This becomes problematic in testground tests, where we need to collect specific data from all nodes, but must avoid overloading an influx instance with all trace data from 100+ nodes.

@evan-forbes evan-forbes added the T:Bug Type: Bug (confirmed) label Nov 27, 2023
@evan-forbes evan-forbes self-assigned this Nov 27, 2023
evan-forbes added a commit that referenced this issue Nov 29, 2023
## Description

There's an viper property or potential bug that stops us from overriding
the default values for slices of strings. The "solution" atm is to use a
string and parse it later like animals later. Unfortunately I think this
is breaking since we're changing what a config is doing so tbh I'm not
sure if we can ever include this in v1. If that's the case then we might
want to consider not merging this to v0.34.x-celestia and only to main.

closes #1141

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
evan-forbes added a commit that referenced this issue Dec 4, 2023
## Description

There's an viper [property or potential
bug](spf13/viper#1366) that stops us from
overriding the default values for slices of strings. The "solution" atm
is to use a string and parse it later like animals later.

closes #1141

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Bug Type: Bug (confirmed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant