Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allows local tracer's push config to be read from env variables #1317

Closed
staheri14 opened this issue Apr 23, 2024 · 0 comments · Fixed by #1318
Closed

allows local tracer's push config to be read from env variables #1317

staheri14 opened this issue Apr 23, 2024 · 0 comments · Fixed by #1318
Assignees
Labels
introspection WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@staheri14
Copy link
Contributor

Currently, the push configuration of the local tracer requires a JSON file containing the credentials for pushing operations. However, in the context of knuu test, it has been suggested to handle these credentials as environment variables rather than as a file. This approach ensures that the credentials persist only as long as the container process is running and are eliminated once the container stops. This reduces the risk of data persistence. Conversely, when credentials are stored in a file, there is a risk that they may persist beyond the lifecycle of the container. This could lead to credential leakage if the storage is reused or accessed by other processes.

Acceptance criteria

Extending the current local tracing pushing configuration by allowing configs to be read from env variables as well. Note that it won't replace the current behaviour i.e., reading from a json file, it merely enables another method to pass the credentials.

@evan-forbes evan-forbes added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols introspection labels Apr 23, 2024
@staheri14 staheri14 self-assigned this Apr 23, 2024
rootulp pushed a commit to rootulp/celestia-core that referenced this issue Sep 20, 2024
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
introspection WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants