Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a new file when reading trace files #1360

Open
evan-forbes opened this issue May 16, 2024 · 0 comments
Open

Return a new file when reading trace files #1360

evan-forbes opened this issue May 16, 2024 · 0 comments
Labels
ice-box issues are automatically assigned this label until they are planned. introspection

Comments

@evan-forbes
Copy link
Member

evan-forbes commented May 16, 2024

Can we return a fresh copy of the file, instead of a pointer to the file? so that the caller can operate on it as it wishes, e.g., closes, etc.

          this is what we did in a previous iteration, and we still had the issue with data being cut off or overwritten in the file. Each file object is supposed to be a descriptor to the file, with its own cursor, so in theory we should be able to do as you say, but for some reason, we still occasionally hit that issue

Originally posted by @evan-forbes in #1340 (comment)

ideally, we'd be able to return a new file that can be used independently from the one that is being written to. When this was tried in the past, we've ran into issues setting the seek for the file. This would sometimes cause the data to be written to the beginning of the file or overwriting previous data.

@evan-forbes evan-forbes added introspection ice-box issues are automatically assigned this label until they are planned. labels May 16, 2024
rootulp pushed a commit to rootulp/celestia-core that referenced this issue Sep 20, 2024
…lestiaorg#1360)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2.10.0 to 3.0.0.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@v2.10.0...v3.0.0)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sergio Mena <sergio@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ice-box issues are automatically assigned this label until they are planned. introspection
Projects
None yet
Development

No branches or pull requests

1 participant