Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tendermint/issue#2639 (preprocessing of blocks) #59

Closed
liamsi opened this issue Sep 10, 2020 · 4 comments
Closed

Implement tendermint/issue#2639 (preprocessing of blocks) #59

liamsi opened this issue Sep 10, 2020 · 4 comments
Labels
C:abci The connection between ll-core and the (abci) app T:investigate Further investigation needed

Comments

@liamsi
Copy link
Member

liamsi commented Sep 10, 2020

It would allow us to more cleanly write the intermediate state roots from the (abci) app into the Block.Data.

Also, clarify if we can also use this mechanism to write the (LL applications') messages into the block data (otherwise we'd have potentially large blobs in the mem pool for no reason).

ref: https://github.com/tendermint/tendermint/issues/2639 (tendermint issue)
ref: https://github.com/marbar3778/tendermint/pull/17 (a first stab on an implementation by @marbar3778)

@tac0turtle
Copy link
Contributor

tac0turtle commented Sep 10, 2020

I'm happy to complete my PR and submit it to lazyledger. Will try to do this in the coming days.

@liamsi liamsi added T:investigate Further investigation needed C:abci The connection between ll-core and the (abci) app labels Sep 10, 2020
@tac0turtle
Copy link
Contributor

I would propose before making this change the DeliverBlock change is made. This change will allow me to pass the proof or metadata associated with the preprocessing of the block easily to the application. This is a feature that the tendermint team is looking into but is not a high priority. After talking with @liamsi this could aid in implementing parts of the lazy-ledger spec.

If there is agreement with this, I can begin to doing needed changes for deliverblock

@liamsi
Copy link
Member Author

liamsi commented Dec 16, 2020

Done in #110.

We probably also want a FinalizeBlock step at the end instead of the sequence of BeginBlock, DeliverTx, EndBlock. But this can happen later in tandem with immediate execution (see diagram in #3).

@liamsi liamsi closed this as completed Dec 16, 2020
@tac0turtle
Copy link
Contributor

I have a branch that is 80% done for finalize block. I can complete it in the coming days and open it against ll core

cmwaters pushed a commit that referenced this issue Mar 13, 2023
* ci: Update Docker build workflows (#59)

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
(cherry picked from commit ddd0117)

# Conflicts:
#	.github/workflows/tendermint-docker.yml

* Resolve conflicts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:abci The connection between ll-core and the (abci) app T:investigate Further investigation needed
Projects
None yet
Development

No branches or pull requests

2 participants