You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When removing malleated txs from the mempool via the mempool's Update method, if the config indicates that the the node should not keep invalid txs in the mempool cache, then it should remove those txs from the cache if they are included in a block. This is not currently occuring because the mempool cache only accepts raw txs and then hashes them itself as opposed to accepting the hashes of the txs.
I don't think this is causing any glaring issues at the moment, but it is effectively overriding the node operator's configuration, which we should eventually fix. To fix this, we need to add a method to the cache to remove a tx by its hash instead of the tx itself. That way we can pass the original tx's hash.
When removing malleated txs from the mempool via the mempool's Update method, if the config indicates that the the node should not keep invalid txs in the mempool cache, then it should remove those txs from the cache if they are included in a block. This is not currently occuring because the mempool cache only accepts raw txs and then hashes them itself as opposed to accepting the hashes of the txs.
celestia-core/internal/mempool/v1/mempool.go
Lines 457 to 459 in 90a27e7
I don't think this is causing any glaring issues at the moment, but it is effectively overriding the node operator's configuration, which we should eventually fix. To fix this, we need to add a method to the cache to remove a tx by its hash instead of the tx itself. That way we can pass the original tx's hash.
celestia-core/internal/mempool/v1/mempool.go
Line 465 in 90a27e7
The text was updated successfully, but these errors were encountered: