Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @liamsi from global CODEOWNERS #857

Closed
rootulp opened this issue Sep 14, 2022 · 0 comments · Fixed by #858
Closed

Remove @liamsi from global CODEOWNERS #857

rootulp opened this issue Sep 14, 2022 · 0 comments · Fixed by #858
Assignees
@rootulp

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 14, 2022 •
edited
Loading

celestia-core/.github/CODEOWNERS

Lines 10 to 13 in c268d1b

* @liamsi @evan-forbes @Wondertan
# Overrides for tooling packages
docs/ @liamsi @adlerjohn

Proposal to:

  • Remove @liamsi from global codeowner to reduce GH notification overload
  • Narrow the docs/ directory to docs/celestia-architecture so that @liamsi @adlerjohn only get tagged for review on Celestia specific ADRs

Motivated by 1:1 discussion with @liamsi
@rootulp rootulp self-assigned this Sep 14, 2022
rootulp added a commit that referenced this issue Sep 14, 2022
@rootulp
Remove @liamsi from global CODEOWNERS
61f876b 
Closes #857
@rootulp rootulp mentioned this issue Sep 14, 2022
Merged
evan-forbes pushed a commit that referenced this issue Sep 19, 2022
@rootulp
Remove @liamsi from global CODEOWNERS (#858)
094cd2c 
Closes #857
cmwaters pushed a commit that referenced this issue Sep 20, 2023
@yihuang
feat: make handshake cancelable (backport #857) (#1012)
60e431e 
it'll make the handshake work with graceful shutdown(see: cosmos/cosmos-sdk#16202)

handshake could be a long running process if there are many local blocks to replay, for example we use it to do profiling.

Hope we can backport this to 0.34.x.

---

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @liamsi from global CODEOWNERS celestiaorg/celestia-core
1 participant
@rootulp