Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default set of trace data collected #978

Closed
evan-forbes opened this issue Mar 10, 2023 · 2 comments
Closed

Add a default set of trace data collected #978

evan-forbes opened this issue Mar 10, 2023 · 2 comments
Assignees

Comments

@evan-forbes
Copy link
Member

I think that often these will be the same data points, thus by just capturing all metrics by default, we save having to rewrite this every time we want to analyse something.

originally posted in #970 (comment) by @cmwaters

In #970, we added the ability to collect arbitrary data into influx db, but didn't add any points in the code where we would actually collect data by default. We should add some default set of collection points.

@evan-forbes
Copy link
Member Author

evan-forbes commented Mar 13, 2023

also ref #970 (comment)

any defaults should be configurable

unrelated to the above comment, we can likely progressively add defaults as we find out what is useful to measure over time. To some extent, this also depends on establishing scripts/pipelines for querying and parsing the default data that is collected

@evan-forbes evan-forbes self-assigned this Aug 7, 2023
@evan-forbes
Copy link
Member Author

this is part of or potentially even blocking celestiaorg/celestia-app#2197

evan-forbes added a commit that referenced this issue Aug 8, 2023
…ensus (#1055)

## Description

This PR updates the trace client with a slight refactor (renaming to be
more consistent) and then adds a few standard tables to store traced
information. We are also able to select which tables we wish to update
(and therefore which information to trace) in the config.

closes #978

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
staheri14 added a commit that referenced this issue Nov 21, 2023
…ensus (#1055)

This PR updates the trace client with a slight refactor (renaming to be
more consistent) and then adds a few standard tables to store traced
information. We are also able to select which tables we wish to update
(and therefore which information to trace) in the config.

closes #978

---------

Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant