feat: commit to original square size in data commitments #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
reviewed
Apr 18, 2023
Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: Rootul P <rootulp@gmail.com>
rootulp
changed the title
This reverts commit ca0aa95.
rootulp
approved these changes
Apr 19, 2023
evan-forbes
approved these changes
Apr 19, 2023
evan-forbes
pushed a commit
that referenced
this pull request
Apr 27, 2023
* feat: commit to original block size in data commitments * chore: block => square size * Update rpc/core/blocks.go Co-authored-by: Rootul P <rootulp@gmail.com> * Update rpc/core/blocks_test.go Co-authored-by: Rootul P <rootulp@gmail.com> * chore: original square size => square size * chore: add uint32 check * Revert "chore: add uint32 check" This reverts commit ca0aa95. * chore: format json --------- Co-authored-by: Rootul P <rootulp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #997
PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments