Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Namespace method to blob #1030

Merged
merged 4 commits into from
Jul 13, 2023
Merged

feat: add Namespace method to blob #1030

merged 4 commits into from
Jul 13, 2023

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented Jul 7, 2023

Addresses this TODO

@rootulp rootulp self-assigned this Jul 7, 2023
@rootulp rootulp changed the title feat: add Namespace method to blob feat: add Namespace method to blob Jul 7, 2023
evan-forbes
evan-forbes previously approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm besides the linter

cmwaters
cmwaters approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@cmwaters cmwaters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that

@rootulp rootulp enabled auto-merge (squash) July 10, 2023 13:34
@rootulp rootulp requested a review from evan-forbes July 10, 2023 13:34
@rootulp rootulp mentioned this pull request Jul 10, 2023
Closed
2 tasks
@rootulp rootulp requested review from rach-id and removed request for evan-forbes July 12, 2023 14:00
@rootulp
Copy link
Collaborator Author

rootulp commented Jul 12, 2023

🤔 hmm does celestia-core have the setting enabled that prevents merge unless the PR is up to date w/ the target branch?

Screenshot 2023-07-12 at 10 36 08 AM

@cmwaters
Copy link
Contributor

Looks like it

@rootulp rootulp merged commit 3e636bb into celestiaorg:v0.34.x-celestia Jul 13, 2023
17 checks passed
@rootulp rootulp mentioned this pull request Jul 14, 2023
Merged
cmwaters added a commit that referenced this pull request Jul 20, 2023
@rootulp @cmwaters
feat: add Namespace method to blob (#1030)
d33554e 
* feat: add Namespace method to blob

* lint

---------

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
cmwaters added a commit that referenced this pull request Jul 24, 2023
@rootulp @cmwaters
feat: add Namespace method to blob (#1030)
8fd1cb2 
* feat: add Namespace method to blob

* lint

---------

Co-authored-by: Callum Waters <cmwaters19@gmail.com>
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmwaters cmwaters cmwaters approved these changes

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes left review comments

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rootulp @cmwaters @rach-id @evan-forbes