feat: remove square size from qgb commitment creation #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmwaters When you have time please |
cmwaters
approved these changes
Jul 26, 2023
yes, it's not gonna be the same commitment. Therefore not the same proofs, and not the same signatures. Good thing we're doing this before mainnet |
rach-id
added a commit
to rach-id/celestia-core
that referenced
this pull request
Jul 26, 2023
## Description Closes celestiaorg#1040 After merging this one, I will cherry-pick this change for main. Then, I will open a separate PR for main to remove the square size and the data hash from the `Data` struct. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
3 tasks
rach-id
added a commit
that referenced
this pull request
Jul 28, 2023
## Description Backports #1047 to main --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments
cmwaters
pushed a commit
that referenced
this pull request
Sep 20, 2023
Closes #666 This PR adds double quotes to `path` param of `/abci_query` endpoint. --- #### PR checklist - [ ] Tests written/updated - [ ] Changelog entry added in `.changelog` (we use [unclog](https://github.com/informalsystems/unclog) to manage our changelog) - [ ] Updated relevant documentation (`docs/` or `spec/`) and code comments (cherry picked from commit f6f13b1f67a54549d9f212a859ca4924d6ad9127) Co-authored-by: Steven Ferrer <steven.r.ferrer@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1040
After merging this one, I will cherry-pick this change for main. Then, I will open a separate PR for main to remove the square size and the data hash from the
Datastruct.PR checklist
.changelog(we useunclog to manage our changelog)
docs/orspec/) and code comments