Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos #1115

Merged
merged 2 commits into from
Oct 24, 2023
Merged

docs: fix typos #1115

merged 2 commits into from
Oct 24, 2023

Conversation

shuoer86
Copy link

No description provided.

rootulp
rootulp previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @shuoer86 ! I think some of these typos could be upstreamed to https://github.com/cometbft/cometbft if you are interested in opening a PR there.

evan-forbes
evan-forbes previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@evan-forbes evan-forbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge imo, but I think the ideal scenario is to actually upstream these first and then merge them here

@shuoer86
Copy link
Author

I will try to upstream. Thank you very much.

@shuoer86 shuoer86 dismissed stale reviews from evan-forbes and rootulp via 5e76645 October 17, 2023 13:28
@shuoer86
Copy link
Author

@rootulp @evan-forbes I have reverted those files forked from cometbft.

rootulp
rootulp approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@rootulp rootulp enabled auto-merge (squash) October 17, 2023 13:33
@rootulp rootulp merged commit 2f2dfcd into celestiaorg:main Oct 24, 2023
15 of 16 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 24, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Celestia Contributor:

GitPOAP: 2023 Celestia Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootulp rootulp rootulp approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

@liamsi liamsi Awaiting requested review from liamsi liamsi is a code owner

@adlerjohn adlerjohn Awaiting requested review from adlerjohn adlerjohn is a code owner

@cmwaters cmwaters Awaiting requested review from cmwaters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shuoer86 @rootulp @evan-forbes @cmwaters