Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): remove GitHub workflow runtime deprecations, ensure lint is up to date #1242

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

ramin
Copy link
Contributor

@ramin ramin commented Feb 27, 2024

Description

Decided to take a look at #1000 and see what was up, seems linting DOES run and is not catching issues that are passed locally, but, while here i noticed some very out of date deprecation warnings on github action runtimes. So:

  • updated actions/checkout to v3 -> v4
  • updated actions/setup-go to v4 -> v5
  • noticed the git diff action was stuck on node16 runtime and deprecated, so replicated behavior with paths in workflow trigger, even though it does require 2 entries (1 for push, 1 for pull_request) seemed cleaner than an unmaintained github action workflow
  • finally: set setup-go to use go.mod for sourcing the go version.

If welcome, i intend to update warnings across all workflows next.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use
    unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

evan-forbes
evan-forbes previously approved these changes Feb 27, 2024
rootulp
rootulp previously approved these changes Feb 28, 2024
Copy link
Collaborator

@rootulp rootulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the outdated deps. I don't understand how this closes #1000 because it looks like none of the lint issues identified in that issue are actually addressed in this PR.

ninabarbakadze
ninabarbakadze previously approved these changes Feb 28, 2024
@rootulp rootulp mentioned this pull request Feb 28, 2024
@ramin
Copy link
Contributor Author

ramin commented Feb 28, 2024

Thanks for bumping the outdated deps. I don't understand how this closes #1000 because it looks like none of the lint issues identified in that issue are actually addressed in this PR.

@rootulp 1000 was the trigger to try and look, but couldn't repro those warnings/errors anymore so cleaned up the rest while in there.

@ramin ramin dismissed stale reviews from ninabarbakadze, rootulp, and evan-forbes via c79d022 March 4, 2024 12:48
go.mod
go.sum
- uses: golangci/golangci-lint-action@v3.7.0
go-version-file: 'go.mod'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[no change needed] 😮 clever! We can remove a few explicit Go versions from CI jobs in celestia-app with this trick.

Ref: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file

Comment on lines 40 to 43
# Required: the version of golangci-lint is required and
# must be specified without patch version: we always use the
# latest patch version.
version: v1.55.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] we could get rid of this comment b/c it's incorrect and bump to latest golangci-lint https://github.com/golangci/golangci-lint/releases/tag/v1.56.2

but we can def do this in a follow up

Copy link
Contributor

@staheri14 staheri14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It may be good to reconsider the Closes #1000 in the PR description as that issue seems to be closed already.

@rootulp
Copy link
Collaborator

rootulp commented Mar 4, 2024

Agreed. Updated the PR description.

@ramin ramin merged commit f781694 into main Mar 5, 2024
16 of 17 checks passed
@ramin ramin deleted the ci/ramin/lint branch March 5, 2024 10:49
cmwaters pushed a commit that referenced this pull request Jul 30, 2024