-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tracing for remaining consensus messages, peer updates, and abci calls #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor!: convert to using a tracer interface feat: add the local client refactor!: fix the schema package feat: decode with types feat!: add ability to change the tracer in the config chore!: remove support for influx chore!: finish purging all things influx chore: remove unnedded e2e setup chore: remove server to reduce changes in this PR chore: linter chore: linter fix: just use the noop for the default tracer to avoid annoying failures feat: concurrently read and write using new a new file and buffer chore: redelete the fileserver fix: give up on being fancy with no mutexes and optimize later docs: add readme docs: update docs in toml fix: go vuln fix: cat mempool tracing chore: go mod tidy reafactor!: rename everything refactor!: convert to using a tracer interface feat: add the local client refactor!: fix the schema package feat: decode with types feat!: add ability to change the tracer in the config chore!: remove support for influx chore!: finish purging all things influx chore: remove unnedded e2e setup chore: remove server to reduce changes in this PR chore: linter chore: linter fix: just use the noop for the default tracer to avoid annoying failures feat: concurrently read and write using new a new file and buffer chore: redelete the fileserver fix: give up on being fancy with no mutexes and optimize later docs: add readme docs: update docs in toml fix: go vuln feat: add the pull based fileserver fix: remove second server in test chore: linter chore: rename chore: linter chore: cleanup old docs feat: add the ability to push traces to an s3 bucket fix: rebase
…eer updates fix: data race in consensus state chore: minor cleanup fix: last usage of cs.Step that was causing the race
evan-forbes
requested review from
cmwaters,
staheri14,
rach-id,
ninabarbakadze and
rootulp
as code owners
April 10, 2024 18:33
rootulp
previously approved these changes
Apr 12, 2024
rach-id
previously approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
staheri14
previously approved these changes
Apr 22, 2024
rach-id
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
evan-forbes
added
the
WS: Big Blonks 🔭
Improving consensus critical gossiping protocols
label
May 13, 2024
staheri14
approved these changes
May 13, 2024
evan-forbes
added a commit
that referenced
this pull request
Jun 3, 2024
## Description This PR backports the fix to the writing and reading of traced files. This enables them to get push correctly every time instead of occasionally get cut from the seek being set to the beginning of the file. it also changes the api by unexporting a function that doesn't need to be exported or included in the interface. these changes are included in the upcoming #1295 --------- Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport of #1292