Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tracing for remaining consensus messages, peer updates, and abci calls #1295

Merged
merged 20 commits into from
May 16, 2024

Conversation

evan-forbes
Copy link
Member

Description

backport of #1292

refactor!: convert to using a tracer interface

feat: add the local client

refactor!: fix the schema package

feat: decode with types

feat!: add ability to change the tracer in the config

chore!: remove support for influx

chore!: finish purging all things influx

chore: remove unnedded e2e setup

chore: remove server to reduce changes in this PR

chore: linter

chore: linter

fix: just use the noop for the default tracer to avoid annoying failures

feat: concurrently read and write using new a new file and buffer

chore: redelete the fileserver

fix: give up on being fancy with no mutexes and optimize later

docs: add readme

docs: update docs in toml

fix: go vuln

fix: cat mempool tracing

chore: go mod tidy

reafactor!: rename everything

refactor!: convert to using a tracer interface

feat: add the local client

refactor!: fix the schema package

feat: decode with types

feat!: add ability to change the tracer in the config

chore!: remove support for influx

chore!: finish purging all things influx

chore: remove unnedded e2e setup

chore: remove server to reduce changes in this PR

chore: linter

chore: linter

fix: just use the noop for the default tracer to avoid annoying failures

feat: concurrently read and write using new a new file and buffer

chore: redelete the fileserver

fix: give up on being fancy with no mutexes and optimize later

docs: add readme

docs: update docs in toml

fix: go vuln

feat: add the pull based fileserver

fix: remove second server in test

chore: linter

chore: rename

chore: linter

chore: cleanup old docs

feat: add the ability to push traces to an s3 bucket

fix: rebase
…eer updates

fix: data race in consensus state

chore: minor cleanup

fix: last usage of cs.Step that was causing the race
@rootulp rootulp removed their request for review April 11, 2024 01:52
rootulp
rootulp previously approved these changes Apr 12, 2024
@evan-forbes evan-forbes linked an issue Apr 15, 2024 that may be closed by this pull request
Base automatically changed from evan/tracer-patch to v0.34.x-celestia April 16, 2024 23:28
@evan-forbes evan-forbes dismissed rootulp’s stale review April 16, 2024 23:28

The base branch was changed.

@evan-forbes evan-forbes requested a review from a team as a code owner April 16, 2024 23:28
rach-id
rach-id previously approved these changes Apr 22, 2024
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

staheri14
staheri14 previously approved these changes Apr 22, 2024
@evan-forbes evan-forbes dismissed stale reviews from staheri14 and rach-id via c52e7c2 May 6, 2024 06:59
@evan-forbes evan-forbes linked an issue May 6, 2024 that may be closed by this pull request
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@evan-forbes evan-forbes added the WS: Big Blonks 🔭 Improving consensus critical gossiping protocols label May 13, 2024
@evan-forbes evan-forbes enabled auto-merge (squash) May 14, 2024 02:28
@evan-forbes evan-forbes merged commit d27374c into v0.34.x-celestia May 16, 2024
21 checks passed
@evan-forbes evan-forbes deleted the evan/tracer-patch-addition branch May 16, 2024 16:46
evan-forbes added a commit that referenced this pull request Jun 3, 2024
## Description

This PR backports the fix to the writing and reading of traced files.
This enables them to get push correctly every time instead of
occasionally get cut from the seek being set to the beginning of the
file.

it also changes the api by unexporting a function that doesn't need to
be exported or included in the interface.

these changes are included in the upcoming #1295

---------

Co-authored-by: Sanaz Taheri <35961250+staheri14@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace remaining consensus messagse Improving block parts traced data
4 participants