Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slack web-hook to be notified about e2e tests #131

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jan 10, 2021

Description

Add slack webhook. See https://github.com/rtCamp/action-slack-notify

Closes: #99

@@ -45,7 +45,7 @@ jobs:
uses: rtCamp/action-slack-notify@ae4223259071871559b6e9d08b24a63d71b3f0c0
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
SLACK_CHANNEL: tendermint-internal
SLACK_CHANNEL: lazyledger-core
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marbar3778 besides adding a secret and a channel that does exist, this does not require any changes, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct

@liamsi liamsi merged commit a688a37 into master Jan 11, 2021
@liamsi liamsi deleted the ismail/slack_hook_e2e branch January 11, 2021 09:39
cmwaters pushed a commit that referenced this pull request Mar 13, 2023
* ci: Fix stalebot config (#131)

I noticed that stalebot wasn't respecting our `wip` label, only to realize I hadn't yet updated its config.

---

#### PR checklist

- [x] Tests written/updated, or no tests needed
- [x] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [x] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed

(cherry picked from commit 9975bc8)

# Conflicts:
#	.github/workflows/stale.yml

* Resolve conflicts

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set slack hook for nightly e2e tests
2 participants